PseudoController now correctly returns a JSON object with correct content-type and encoding #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent-type and encoding. Fixed missing NULL_VALUE metric in PseudoField and don't rely on missing sidSnapshotDate when setting MISSING_SID metric.
Andilun
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micronaut attemps to wrap the
HttpResponse<Publisher<String>>into a JSON array - which is not correct. According to the docs one can avoid this by returningHttpResponse<Flowable<byte[]>>instead.Also fixed missing
NULL_VALUEmetric in PseudoField and don't rely on missingsidSnapshotDatewhen settingMISSING_SIDmetric.This fixed the internal ticket ID: DPSTAT-839