Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #129 - Updates the translation management based on the revised data structure:
locales
as the primary data model, instead ofXlsformTemplateLanguage
. This gives us more flexibility, and clarifies the purpose ofLocale
within the data structure.The workflow is as follows:
(The statuses are unchanged from the previous version, but the way they are calculated is changed because locales are now linked to moduleVersions instead of directly to templates.
The teams must select exactly 1 locale for each of their languages. This way we prevent teams accidentally taking 2 translations for the same language (which is technically possible in ODK, but frowned upon and should never be needed).
For a Locale, teams may:
(This does mean there will be some curation and management required to keep the list of Locales tidy over time, but I don't think it will be a lot of work and is probably something someone should be doing anyway...)
Things To Do
This PR focuses on the functionality. There are some key things we should do in future PRs to improve this: