Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xlsform Templates Resource, View Page, Minor Refinements #58

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

dan-tang-ssd
Copy link
Contributor

This PR is submitted to fix #48

It is now ready for review.

It contains below changes:

  • make top section non collapsible
  • add colour to icon for "Available to Platform users?" entry (yes = green; no = grey)
  • Add action (in section or in page header?) to mark template as available

Questions:

  1. I think a "Make Template Available" button is good enough to provide a convenient and obvious way to make a template available. Probably we do not need to provide a convenient way to make a template unavailable. Um... How likley we need to make a template unavailable...?

Copy link
Member

@dave-mills dave-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine, but you made these changes in the odk-link package, rather than only working in the holpa platform repo as I had asked.

In the odk-link package, your new branch was taken from the 5-month-old commit that was being used in Holpa, and now that branch cannot be easily merged into the dev branch because it doesn't include the latest dev changes. This will be a bit complicated, which is why I had said we should work in the single repo to get things done more quickly.

That said, now this is in the odk-link package, it doesn't make sense to move it out, only to move it back in next month. I will reconcile your branch with the dev branch and fix the dev branch so it works on HOLPA, then pass it back to you to review.

@dave-mills
Copy link
Member

@dan-tang-ssd - I have done the following in the filament-odk-link package:

  1. merged your package PR (xlsform templates resource, view page, minor refinements filament-odk-link#44) into dev;
  2. fixed the namespacing and class issues on a new branch and sent you a PR: move required classes out of \App into package; fix namespacing + class names filament-odk-link#45
  3. Switched to using that PR branch here.

This refine-xlsform-template branch should now be working, and be on the latest version of the odk-link package. Can you check it loads ok? if it's good, then we can merge the package PR back to dev, update this branch to reference dev in the package, then merge this branch in 👍 .

@dan-tang-ssd
Copy link
Contributor Author

@dave-mills - Thanks a lot.

Here is what I did, I think it is good to merge.

==========

main repo

git checkout dev

git pull

git checkout refine-xlsform-template-view-page

git pull

==========

submodule

git checkout dev

git pull

git checkout namespace-fixing

git pull

==========

perform testing, check if 3 changes in this PR remains unchange, success


Screen shots:

image

image


Questions:

  1. In Xlsform Templates resource, list view, previously it shows all xlsform_templates record (with error 504 Gateway timeout). But now it only shows xlsform_templates that created successfully during creation process. Is this the expected behaviour?

Screen shots:

image

image

@dave-mills
Copy link
Member

In Xlsform Templates resource, list view, previously it shows all xlsform_templates record (with error 504 Gateway timeout). But now it only shows xlsform_templates that created successfully during creation process. Is this the expected behaviour?

Yes. The view now shows only xlsformtemplates owned by the 'platform', to have the opportunity for individual programs/teams/users to also own xlsformtemplates. This has the added feature of only showing templates that were successfully processed during creation.

@dave-mills dave-mills merged commit d3dbb1e into dev Dec 3, 2024
@dave-mills dave-mills deleted the refine-xlsform-template-view-page branch December 4, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODK form template availability - make it easier to see/update
2 participants