Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove protoc-gen-go scripts #16493

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −17
Draft

chore: remove protoc-gen-go scripts #16493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/macos_build_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function check_version {

function install_build_dependencies {
echo "Install build dependencies"
brew install cmake pkg-config libtool jq node@18 yarn protoc-gen-go
brew install cmake pkg-config libtool jq node@18 yarn
}

function install_qt {
Expand Down
2 changes: 1 addition & 1 deletion scripts/ubuntu_build_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function install_build_dependencies {
echo "Install build dependencies"
apt update
apt install -yq git wget build-essential \
cmake extra-cmake-modules pkg-config protoc-gen-go \
cmake extra-cmake-modules pkg-config \
mesa-common-dev unixodbc-dev libpq-dev libglu1-mesa-dev libpcsclite-dev \
libpcre3-dev libssl-dev libpulse-mainloop-glib0 libxkbcommon-x11-dev
}
Expand Down
15 changes: 0 additions & 15 deletions scripts/windows_build_setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,6 @@ function Install-Scoop {
}
}

# Install Protobuf tool necessary to generate status-go files.
function Install-Protobuf-Go {
$ProtocGenVersion = "v1.34.1"
$ProtocGenZIP = "protoc-gen-go.$ProtocGenVersion.windows.amd64.zip"
$ProtocGenURL = "https://github.com/protocolbuffers/protobuf-go/releases/download/$ProtocGenVersion/$ProtocGenZIP"
$ProtocGenSHA256 = "403a619c4698fe5c4162c7f855803de3e8d8e0c187d7d51cbeb8d599f7a5a073"
(New-Object System.Net.WebClient).DownloadFile($ProtocGenURL, "$env:USERPROFILE\$ProtocGenZIP")
$ProtocGenRealSHA256 = (Get-Filehash -algorithm SHA256 "$env:USERPROFILE\$ProtocGenZIP").Hash
if ($ProtocGenRealSHA256 -ne $ProtocGenSHA256) {
throw "SHA256 hash does not match for $ProtocGenZIP !"
}
New-Item "$env:USERPROFILE\go\bin" -ItemType Directory -ea 0
7z x -o="$env:USERPROFILE\go\bin" -y "$env:USERPROFILE\$ProtocGenZIP"
}

# Install Git and other dependencies
function Install-Dependencies {
Expand Down Expand Up @@ -104,7 +90,6 @@ $QtVersion = "5.15.2"
If ($MyInvocation.InvocationName -ne ".") {
Install-Scoop
Install-Dependencies
Install-Protobuf-Go
Install-Qt-SDK
Install-VC-BuildTools
Show-Success-Message
Expand Down