Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use 1 content-topic for all chats within a community (not to be merged) #16495

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Oct 9, 2024

What does the PR do

This PR is mainly to dogfood underlying changes made in status-go.

Reference PR status-im/status-go#5864 which has details.

This PR uses single content-topic for all community chats to send messages. It still receives messages on all existing content-topics used by previous versions in order to maintain compatibility.

Details of the discussion are available https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335/29

Affected areas

communities

Impact on end user

What is the impact of these changes on the end user (before/after behaviour)

How to test

  • This PR would require complete testing of communities in relay and light modes.
  • It would also require to be tested for compacibility with older version of the code.
  • Best to check all admin functions as well using this new code
  • We also need to validate if community admin is using older code and a member is using new code there are no incompatibilites.
  • All chats and community flows such as add member, remove member, add channel, delete channel, change permissions to channels etc

Risk

No risk is seen because this change will not break compatibility.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

@chaitanyaprem chaitanyaprem requested a review from a team as a code owner October 9, 2024 10:26
@chaitanyaprem chaitanyaprem requested review from noeliaSD and removed request for a team October 9, 2024 10:26
@chaitanyaprem chaitanyaprem marked this pull request as draft October 9, 2024 10:26
@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ be3dc28 #1 2024-10-09 10:33:30 ~7 min tests/nim 📄log
✔️ be3dc28 #1 2024-10-09 10:35:08 ~8 min macos/aarch64 🍎dmg
✔️ be3dc28 #1 2024-10-09 10:39:51 ~13 min tests/ui 📄log
✔️ be3dc28 #1 2024-10-09 10:42:28 ~15 min macos/x86_64 🍎dmg
✔️ be3dc28 #1 2024-10-09 10:43:21 ~16 min linux-nix/x86_64 📦tgz
✔️ be3dc28 #1 2024-10-09 10:44:17 ~17 min linux/x86_64 📦tgz
✔️ 459f9e6 #3 2024-10-17 08:08:40 ~7 min tests/nim 📄log
✔️ 459f9e6 #3 2024-10-17 08:10:01 ~8 min macos/aarch64 🍎dmg
✔️ 459f9e6 #3 2024-10-17 08:13:54 ~12 min tests/ui 📄log
✔️ 459f9e6 #3 2024-10-17 08:17:43 ~16 min linux-nix/x86_64 📦tgz
✔️ 459f9e6 #3 2024-10-17 08:17:59 ~16 min macos/x86_64 🍎dmg
✔️ 459f9e6 #3 2024-10-17 08:20:10 ~18 min linux/x86_64 📦tgz
✔️ 459f9e6 #3 2024-10-17 08:23:35 ~21 min windows/x86_64 💿exe

@status-im-auto
Copy link
Member

@chaitanyaprem
Copy link
Collaborator Author

Dogfooded by @weboko and @jm-clius as part of waku dogfooding session and here are details. So, looks like developer dogfooding is done and did not find any issues so far. Will wait for QA to dogfood post 2.31 release (especially acting as control node and doing various community admin operations).

  • We tried 1 new version and 2 old, then 2 new and one master.
  • Relay and light mode as well, we did dms and waku test community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants