Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/deep link 16345 with unfurl #16554

Closed

Conversation

Cuteivist
Copy link
Contributor

Note: Already reviewed in #16541 (merge by mistake)

Task #16412

User stories: https://www.notion.so/Transaction-deep-link-10d8f96fb65c803c85fed5f4440ad439

Status-go : status-im/status-go#5958

What does the PR do

  • Added unfurling of transaction deep links
  • Added preview mini card for transaction preview (chat input)
  • Added chat preview card for transaction preview
  • Updated storybook

NOTE that this feature is behind feature flag. The design is not finished yet.

Affected areas

Chat

Architecture compliance

Screenshot of functionality (including design for comparison)

unfurling.mov

Impact on end user

What is the impact of these changes on the end user (before/after behaviour)

How to test

  • How should one proceed with testing this PR.

SET FLAG_TRANSACTION_DEEP_LINK_ENABLED env variable to 1 before running Status

  • What kind of user flows should be checked?

Send / Bridge / Swap share button pasting

Risk

Described potential risks and worst case scenarios.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

@Cuteivist Cuteivist requested review from dlipicar and virginiabalducci and removed request for a team October 21, 2024 10:29
@Cuteivist Cuteivist closed this Oct 21, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Oct 21, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 186b8d0 #1 2024-10-21 10:37:10 ~6 min tests/nim 📄log
✔️ 186b8d0 #1 2024-10-21 10:38:50 ~8 min macos/aarch64 🍎dmg
✔️ 186b8d0 #1 2024-10-21 10:42:31 ~12 min tests/ui 📄log
✔️ 186b8d0 #1 2024-10-21 10:45:02 ~14 min macos/x86_64 🍎dmg
✔️ 186b8d0 #1 2024-10-21 10:49:34 ~19 min linux/x86_64 📦tgz
✔️ 186b8d0 #1 2024-10-21 10:51:10 ~20 min windows/x86_64 💿exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants