Feat/update launch send modal mechanism #16718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
force-pushed
the
feat/UpdateLaunchSendModalMechanism
branch
from
379561d
to
db6dafa
Compare
Jenkins BuildsClick to see older builds (16)
|
Khushboo-dev-cpp
force-pushed
the
feat/UpdateLaunchSendModalMechanism
branch
from
db6dafa
to
9845809
Compare
Khushboo-dev-cpp
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
Cuteivist
and removed request for
a team
Khushboo-dev-cpp
force-pushed
the
feat/UpdateLaunchSendModalMechanism
branch
from
9845809
to
ab5fe7f
Compare
Khushboo-dev-cpp
force-pushed
the
feat/UpdateLaunchSendModalMechanism
branch
from
ab5fe7f
to
5c1e2e7
Compare
alaibe
approved these changes
Nov 6, 2024
… architecture guidelines. After this change there is not need to pass sendModal instance from AppMain to other parts of app. Then SendModal should be launched simply by calling Global.openSendModal(....)
Khushboo-dev-cpp
force-pushed
the
feat/UpdateLaunchSendModalMechanism
branch
from
5c1e2e7
to
d389808
Compare
caybro
requested changes
Nov 8, 2024
| @@ -241,7 +238,7 @@ QtObject { | |||
| Global.openFinaliseOwnershipPopup(actionData) | |||
| return | |||
| case ToastsManager.ActionType.OpenSendModalPopup: | |||
| root.sendModalPopup.open() | |||
| Global.openSendModal() | |||
There was a problem hiding this comment.
This won't work most likely; the signal needs to be passed all the params
| @@ -72,7 +71,13 @@ QtObject { | |||
| signal setNthEnabledSectionActive(int nthSection) | |||
| signal appSectionBySectionTypeChanged(int sectionType, int subsection, int subSubsection, var data) | |||
|
|
|||
| signal openSendModal(string address) | |||
| signal openSendModal(int sendType, string senderAddress, | |||
There was a problem hiding this comment.
... that said, this should/could be a simple function instead, with defaulted parameters, and then you can just re-emit a similar signal with all the parameters, instead of having to fill all the params to this signal here
| if (interactive === undefined) interactive = true | ||
| if (publicKey === undefined) publicKey = "" | ||
| if (ensName === undefined) ensName = "" | ||
| if (stickersPackId === undefined) stickersPackId = "" |
There was a problem hiding this comment.
... and this will become much easier because you will have all the defaults already in
| req.preSelectedRecipientType, //recipientType | ||
| false, //onlyAssets | ||
| true, //interactive | ||
| "", //publicKey |
There was a problem hiding this comment.
... and finally you could omit all the empty/default/uninteresting parameters here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Changes the SendModal launching mechanish.
Update signals in Global for openSendModal to be parameterised, instead of having to pass sendModal instance across the app.
Affected areas
SendModal Invocations points from-
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
SendVia1-1Chat.mov
TransferOwnership.mov
TransactionsHistorySend.mov
Screen.Recording.2024-11-05.at.9.49.43.PM.mov
profileShowcaseMenu.mov
BuyStickers.mov
MainWalletSavedAddresses.mov
MainWalletViewSend.mov
RegisterEns.mov