You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We usually ignore those. And it makes codeclimate usnuable, because it's hard to see real problems behind this mess.
Proposal
Let's increase the methods number limit. I think it's legit for such a big project as status-go
I'd say 50 is reasonable number.
Of course we still have Messenger and API structs which have hundrends of methods. So for these particular cases (and some other) I'd mark them as Invalid or Wontfix in codeclimate. We can come up with a list of exceptions in CONTRIBUTION.md.
The number of lines limit is set to 900, this sounds big enough for me already.
We should really consider refactoring and splitting into multiple files.
But since we're not doing that, maybe bump it to, let's say, 1500 lines?
I'd also propose to make exceptions for *_test.go files for these 2 limits, If it's possible to configure.
Notes
If we're considering making codeclimate's test coverage required to merge PRs, then increasing this limits is essential.
The text was updated successfully, but these errors were encountered:
Problem
Most of the code smells in codeclimate are:
...
has N methods (exceeds 21 allowed)...
has N lines of code (exceeds 900 allowed)We usually ignore those. And it makes codeclimate usnuable, because it's hard to see real problems behind this mess.
Proposal
Let's increase the methods number limit. I think it's legit for such a big project as status-go
I'd say 50 is reasonable number.
Of course we still have
Messenger
andAPI
structs which have hundrends of methods. So for these particular cases (and some other) I'd mark them asInvalid
orWontfix
in codeclimate. We can come up with a list of exceptions inCONTRIBUTION.md
.The number of lines limit is set to 900, this sounds big enough for me already.
We should really consider refactoring and splitting into multiple files.
But since we're not doing that, maybe bump it to, let's say, 1500 lines?
I'd also propose to make exceptions for
*_test.go
files for these 2 limits, If it's possible to configure.Notes
If we're considering making codeclimate's test coverage
required
to merge PRs, then increasing this limits is essential.The text was updated successfully, but these errors were encountered: