chore_: configure codeclimate #6006
Open
+2
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
force-pushed
the
chore/configure-codeclimate
branch
from
ada6a5c
to
e67f09e
Compare
Jenkins BuildsClick to see older builds (8)
|
igor-sirotin
force-pushed
the
chore/configure-codeclimate
branch
from
e67f09e
to
83b36bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6006 +/- ##
===========================================
- Coverage 60.88% 60.85% -0.04%
===========================================
Files 811 811
Lines 108894 108894
===========================================
- Hits 66303 66266 -37
- Misses 34841 34864 +23
- Partials 7750 7764 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
No idea why Codeclimate decided to complain about some 59 code duplications that were there all the time 🤔 Will monitor the check before making it required. |
igor-sirotin
force-pushed
the
chore/configure-codeclimate
branch
from
83b36bf
to
98cebdc
Compare
ilmotta
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it's time to make Codeclimate quality checks required.
These threshold increases will make our life easier (although I don't like the numbers, it's too high).
Closes #4491