Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BC)_: Notify client on dapp connection changes #6051

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Nov 6, 2024

  1. Include chainIds and account on PermissionsGranted client signal.
  2. Send a client event whenever the dapp permissions have been revoked.
  • update tests

PR needed for status-im/status-desktop#16044

@status-im-auto
Copy link
Member

status-im-auto commented Nov 6, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 38f10af #1 2024-11-06 07:35:24 ~4 min tests 📄log
✔️ 38f10af #1 2024-11-06 07:35:32 ~4 min macos 📦zip
✔️ 38f10af #1 2024-11-06 07:35:48 ~4 min tests-rpc 📄log
✔️ 38f10af #1 2024-11-06 07:35:59 ~5 min ios 📦zip
✔️ 38f10af #1 2024-11-06 07:36:29 ~5 min linux 📦zip
✔️ 38f10af #1 2024-11-06 07:36:53 ~6 min android 📦aar
✔️ 38f10af #1 2024-11-06 07:37:04 ~6 min windows 📦zip
✔️ 38f10af #1 2024-11-06 07:37:47 ~6 min macos 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ ba2baec #2 2024-11-07 09:22:03 ~2 min tests 📄log
✔️ ba2baec #2 2024-11-07 09:23:13 ~4 min windows 📦zip
✔️ ba2baec #2 2024-11-07 09:23:38 ~4 min macos 📦zip
✔️ ba2baec #2 2024-11-07 09:23:44 ~4 min tests-rpc 📄log
✔️ ba2baec #2 2024-11-07 09:23:56 ~4 min ios 📦zip
✔️ ba2baec #2 2024-11-07 09:24:37 ~5 min linux 📦zip
✔️ ba2baec #2 2024-11-07 09:24:47 ~5 min android 📦aar
✔️ ba2baec #2 2024-11-07 09:26:16 ~7 min macos 📦zip
✔️ d4239ac #3 2024-11-09 12:57:38 ~4 min tests-rpc 📄log
✔️ d4239ac #3 2024-11-09 12:57:47 ~4 min macos 📦zip
✔️ d4239ac #3 2024-11-09 12:58:02 ~4 min windows 📦zip
✔️ d4239ac #3 2024-11-09 12:58:12 ~4 min ios 📦zip
✔️ d4239ac #3 2024-11-09 12:58:22 ~5 min linux 📦zip
✔️ d4239ac #3 2024-11-09 12:58:34 ~5 min android 📦aar
✔️ d4239ac #3 2024-11-09 13:01:57 ~8 min macos 📦zip
✔️ d4239ac #3 2024-11-09 13:27:50 ~34 min tests 📄log

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.79%. Comparing base (b329b15) to head (d4239ac).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
services/connector/commands/client_handler.go 57.89% 4 Missing and 4 partials ⚠️
services/connector/api.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6051      +/-   ##
===========================================
- Coverage    60.88%   60.79%   -0.09%     
===========================================
  Files          811      811              
  Lines       108894   108916      +22     
===========================================
- Hits         66303    66220      -83     
- Misses       34841    34919      +78     
- Partials      7750     7777      +27     
Flag Coverage Δ
functional 13.06% <10.34%> (-0.02%) ⬇️
unit 60.16% <68.96%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/connector/commands/request_accounts.go 84.61% <100.00%> (ø)
services/connector/commands/rpc_traits.go 80.00% <ø> (ø)
services/connector/commands/test_helpers.go 100.00% <100.00%> (ø)
signal/events_connector.go 100.00% <100.00%> (ø)
services/connector/api.go 69.62% <50.00%> (ø)
services/connector/commands/client_handler.go 79.36% <57.89%> (-3.97%) ⬇️

... and 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants