Fix MidRaidQuestChangePatch null check and improve logging #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkaMoez
changed the title
OkaMoez
commented
Jan 29, 2024
| Logger.LogError($"[MidRaidQuestChangePatch] questController instance was null"); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
Not sure what's going on with the formatting here. It looks normal inside Visual Studio for me locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently added
MidRaidQuestChangePatchhas a inverted null check ongameWorld.This change fixes that check, converts the second null check into a guard clause, and slightly improves logging in the patch.