Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] fix mia on server-sent stop #284

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

belettee
Copy link
Contributor

@belettee belettee commented Apr 24, 2024

Hotfix for now, but the whole extract+quit out logic will need to be simplified/unified in the next major release.

Sequence of events triggering the bug:

  • guest extracts (regardless of exfil type/map)
  • guest's collider is disabled so that existing players do not get bodyblocked
  • no more collision with exfil point means OnCancelExtraction is called, which has new "runner" detection logic, setting the exit status to mia (restoring "default" value)
  • host quits (i.e. pressed F8)
  • host's profileId is before guest's profileId in the Players list
  • host "kicks" all players including itself before it "kicks" the guest
  • nodejs server sees host left, sends a "everybody leave now!" message to all remaining connected players, including guest
  • guest leaves without recomputing its exit status, which was set to MIA by OnCancelExtraction above
  • player sad

Copy link

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 1b02684
Logs https://github.com/stayintarkov/StayInTarkov.Client/actions/runs/8817622574
Download https://github.com/stayintarkov/StayInTarkov.Client/suites/23103005096/artifacts/

@mihaicm93 mihaicm93 merged commit 2682798 into stayintarkov:master Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants