Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move despawning to SITGameComponent & Fix CleanUp in CoopSitGame #307

Merged
merged 8 commits into from
May 18, 2024
Merged

Move despawning to SITGameComponent & Fix CleanUp in CoopSitGame #307

merged 8 commits into from
May 18, 2024

Conversation

ArchangelWTF
Copy link
Contributor

@ArchangelWTF ArchangelWTF commented May 3, 2024

Moves despawning to SIT's EverySecondCoroutine, adds queueing for despawning, also fixes up the exception(s) in CoopSITGame by checking if the player has already been removed (null)

Copy link

github-actions bot commented May 3, 2024

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 0b793c1
Logs https://github.com/stayintarkov/StayInTarkov.Client/actions/runs/9141982340
Download https://github.com/stayintarkov/StayInTarkov.Client/suites/23930333829/artifacts/1516085155

@ArchangelWTF ArchangelWTF changed the title Move despawning to SITGameComponent Move despawning to SITGameComponent & Fix CleanUp in CoopSitGame May 4, 2024
commit 715ab79
Merge: 302ad6a 3bf9032
Author: devbence / bullet <[email protected]>
Date:   Sat May 11 03:22:05 2024 +0200

    Fix IsHostileToEverybodyPatch sptusecbear numbers (#315)

    - Fixes IsHostileToEverybodyPatch sptusecbear numbers so they match Aki
    3.8.*
    - Fixes bug on Scav mode

commit 302ad6a
Merge: b69c66d 758a255
Author: devbence / bullet <[email protected]>
Date:   Sat May 11 03:19:30 2024 +0200

    Fix Sync of usage of bullets between Clients (#313)

    Fixes Sync of usage of bullets between Clients by effectively popping
    and pushing bullet items into the chamber and then removing them when
    needed.

commit 758a255
Author: Paulov <[email protected]>
Date:   Fri May 10 23:52:33 2024 +0100

    Cleanup InitiateShotPacket usings

commit 3bf9032
Author: Paulov <[email protected]>
Date:   Fri May 10 23:49:36 2024 +0100

    change role numbers to 47 and 48 as used by aki 3.8.*

commit 5ac7d06
Author: Paulov <[email protected]>
Date:   Thu May 9 16:20:31 2024 +0100

    Fix Camora / Cylinder bullet use sync

commit 96f8bf6
Author: Paulov <[email protected]>
Date:   Tue May 7 23:23:20 2024 +0100

    Fix the sync of usage of bullets in guns between clients

commit b69c66d
Merge: 6343f59 a4e7ff3
Author: devbence / bullet <[email protected]>
Date:   Wed May 8 00:13:26 2024 +0200

    Fix IBotGame not existing on client (#312)

    This fixes several errors in the console when using mods like DrakiaXYZ
    Waypoints because IBotGame was not being instantiated on the Clients

commit a4e7ff3
Author: Paulov <[email protected]>
Date:   Tue May 7 22:25:14 2024 +0100

    Fix error with mods on Client because IBotGame was not being instantiated

commit 6343f59
Merge: 4bb2517 224aab7
Author: Paulov <[email protected]>
Date:   Tue May 7 15:59:09 2024 +0100

    Fix Player Extraction Sync (#311)

    - Sends a packet when a Player Extracts
    - Fixes bug where host could not extract

commit 224aab7
Merge: dad9f86 b03d001
Author: Paulov <[email protected]>
Date:   Tue May 7 15:57:17 2024 +0100

    Merge branch 'refactor/player-extraction' of https://github.com/stayintarkov/StayInTarkov.Client into refactor/player-extraction

commit dad9f86
Author: Paulov <[email protected]>
Date:   Wed May 1 08:10:27 2024 +0100

    Remove unused fields/properties

commit 2f2c473
Author: Paulov <[email protected]>
Date:   Tue Apr 30 19:21:24 2024 +0100

    Refactored Player Extraction and Fixed issues with host

commit 4bb2517
Merge: 6834296 491cdaf
Author: Paulov <[email protected]>
Date:   Tue May 7 15:26:33 2024 +0100

    Cleanup unused replication out of patches, remove ActionPackets  & ActionPacketsMovement  (#296)

    As I was tracking down #294 yesterday I initially ended up trying to fix
    the wrong things as there was a lot of code that is now unused or
    legacy, this cleans at least a bit of that up and should make tracking
    down packet issues more easy.

commit 6834296
Merge: a633458 8472823
Author: Paulov <[email protected]>
Date:   Tue May 7 15:23:16 2024 +0100

    Raid Statuses (#310)

    Working with the Server mod changes so Raids now have a status rather
    than using player counts to determine whether they are joinable

commit a633458
Merge: cf2c7e2 12843d4
Author: Paulov <[email protected]>
Date:   Tue May 7 15:22:43 2024 +0100

    [fix] no update for bots (#302)

    removes: `getCoopMatch -- no server of xxx exists` on raid end

commit cf2c7e2
Merge: 3fab35b 6cbc8c3
Author: Paulov <[email protected]>
Date:   Tue May 7 15:21:25 2024 +0100

    Flea Market 0.0.0.0 WS bug (#303)

    This extends `WebSocketPatch.cs` to fix the 0.0.0.0 bug by replacing the
    websocket address received from the server with the one we already
    received through launch params.

commit 8472823
Author: Paulov <[email protected]>
Date:   Tue May 7 15:15:53 2024 +0100

    Add information bar for further features

commit 3fab35b
Merge: 7ede630 4726367
Author: Paulov <[email protected]>
Date:   Tue May 7 15:03:02 2024 +0100

    make bot teleport distance configurable. (#309)

    40 do seem a little short, leave it to you guys to set new default.

commit 4726367
Author: null <[email protected]>
Date:   Sun May 5 18:11:26 2024 -0700

    make bot teleport distance configurable.

commit 491cdaf
Author: Archangel <[email protected]>
Date:   Sat May 4 15:38:14 2024 +0200

    Remove, was included in merge

commit 924c008
Merge: 7c7c6bd 7ede630
Author: Archangel <[email protected]>
Date:   Sat May 4 15:33:21 2024 +0200

    Merge branch 'development' into cleanup_unused_replication

commit a2889f8
Author: Paulov <[email protected]>
Date:   Thu May 2 20:03:01 2024 +0100

    Rearrange some of the matchmaker screen

commit 5df7d25
Author: Paulov <[email protected]>
Date:   Thu May 2 18:09:05 2024 +0100

    Refactor to support a Raid Status (WAITING, IN GAME etc)

commit 6cbc8c3
Author: Jackson Abney <[email protected]>
Date:   Thu May 2 07:15:04 2024 +0000

    Use UriBuilder instead

commit 5f6df01
Author: Jackson Abney <[email protected]>
Date:   Thu May 2 01:11:47 2024 +0000

    Expand WebSocketPatch.cs to cover the 0.0.0.0 bug that causes Flea Market issues

commit 12843d4
Author: bullet <[email protected]>
Date:   Wed May 1 18:12:01 2024 +0200

    no need to say goodbye for the bots

    removes getCoopMatch -- no server of xxx exists

commit b03d001
Author: Paulov <[email protected]>
Date:   Tue Apr 30 19:21:24 2024 +0100

    Refactored Player Extraction and Fixed issues with host

commit 8f282d3
Merge: 30c1101 a9129ed
Author: Mihai <[email protected]>
Date:   Mon Apr 29 16:11:12 2024 +0200

    Translated README_CN to Simplified Chinese (#295)

commit 7c7c6bd
Author: Archangel <[email protected]>
Date:   Mon Apr 29 10:58:24 2024 +0200

    Cleanup unused Actionpackets & ActionpacketsMovement code, removes replication out of patches as this was used by Actionpackets & Actionpacketsmovement

commit a9129ed
Author: dounai2333 <[email protected]>
Date:   Mon Apr 29 15:23:47 2024 +0800

    Translated README_CN to Simplified Chinese

commit 30c1101
Merge: 0b62510 5007406
Author: Paulov <[email protected]>
Date:   Mon Apr 29 08:02:37 2024 +0100

    Replaced the old ReadMe (#293)

    This PR will replace the previous ReadMe files that had the old
    installation instructions with the new ReadMe file.

    It will require new translation done on each page

commit 5007406
Author: Mihai <[email protected]>
Date:   Mon Apr 29 04:58:51 2024 +0200

    Update README_DE.md

commit bb83e0c
Author: Mihai <[email protected]>
Date:   Mon Apr 29 04:58:35 2024 +0200

    Update README_FR.md

commit 0c92c6b
Author: Mihai <[email protected]>
Date:   Mon Apr 29 04:58:20 2024 +0200

    Update README_KO.md

commit 917ad32
Author: Mihai <[email protected]>
Date:   Mon Apr 29 04:58:05 2024 +0200

    Update README_PO.md

commit 75fc112
Author: Mihai <[email protected]>
Date:   Mon Apr 29 04:57:51 2024 +0200

    Update README_JA.md

commit 02e434a
Author: Mihai <[email protected]>
Date:   Mon Apr 29 04:56:53 2024 +0200

    Update README_CN.md
@paulov-t paulov-t self-requested a review May 18, 2024 19:01
Copy link
Contributor

@paulov-t paulov-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small changes for performance but all is good. Thanks @ArchangelWTF

@paulov-t paulov-t merged commit c5f8311 into stayintarkov:development May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants