Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed disabling SCAV-Mode #9

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

TehFl0w
Copy link
Contributor

@TehFl0w TehFl0w commented Nov 18, 2023

Fixed disabling SCAV-Mode and moved PMC object to center, may need additional logic on resolutions other than 1080p

grafik

Fixed disabling SCAV-Mode and moved PMC object to center
Copy link
Contributor

@trippyone trippyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not centered in 2K.

image

@TehFl0w
Copy link
Contributor Author

TehFl0w commented Nov 19, 2023

Yeah I already noticed it while moving/scaling windows around, I'll think about something

Updated logic for pmc-element-centering
Copy link
Contributor

@trippyone trippyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately same results.

image

@TehFl0w TehFl0w closed this Nov 19, 2023
@TehFl0w TehFl0w reopened this Nov 20, 2023
@Lacyway
Copy link
Contributor

Lacyway commented Nov 20, 2023

Get the parent Canvas Group transform instead and use that to scale it with math.
Can you try this on different resolutions?

var mmSSC = pmcs.transform.parent.gameObject;

pmcs.transform.position = new Vector3(mmSSC.transform.position.x / 1.305f, pmcs.transform.position.y * 0.75f, 0);

@Lacyway Lacyway requested review from Lacyway and removed request for Lacyway November 20, 2023 10:33
@ArchangelWTF
Copy link
Contributor

That scaling seems to do the trick, the selection for it stays nicely in the middle now. (Tested at 720, 1080, 1440, 4k)

@Lacyway
Copy link
Contributor

Lacyway commented Nov 20, 2023

That scaling seems to do the trick, the selection for it stays nicely in the middle now. (Tested at 720, 1080, 1440, 4k)

I have tested it as well on 16:9 and 4:3, seems to always be fine.
@trippyone will you try and approve PR?

@Lacyway Lacyway self-requested a review November 21, 2023 09:23
@Lacyway Lacyway requested review from trippyone and removed request for trippyone November 21, 2023 09:26
@Lacyway Lacyway self-assigned this Nov 21, 2023
@dounai2333 dounai2333 merged commit aec6e03 into stayintarkov:master Nov 21, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants