Add component for selecting rpc #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyBerrysBoy
commented
Apr 20, 2023
HappyBerrysBoy
commented
- Add Component in the setting page
- Add RPC Node List in the default.json
- Change api endpoint for loading posting/comments
- Main.js Bug Fix(steemSelectedRpc => !steemSelectedRpc) - Set state(rpcNode, rpcError) - Show rpcError under component when invalid rpc url format
DoctorLai
reviewed
Apr 21, 2023
|
|
||
| validateUrlFormat(url) { | ||
| if (!url) return false; | ||
| if (!/^https?:\/\//.test(url)) return false; |
There was a problem hiding this comment.
Are we enforcing a HTTPS here? Also, check this for a more complex reg: https://stackoverflow.com/questions/8667070/javascript-regular-expression-to-validate-url
There was a problem hiding this comment.
I fixed this.
Thanks for your kindly review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.