Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit diagnostic/debug event design #731

Closed
4 tasks
sisuresh opened this issue Mar 16, 2023 · 1 comment
Closed
4 tasks

Revisit diagnostic/debug event design #731

sisuresh opened this issue Mar 16, 2023 · 1 comment

Comments

@sisuresh
Copy link
Contributor

sisuresh commented Mar 16, 2023

Currently, we have three types of host events -

  1. Contract events - metered, hashed into the ledger, and included in tx meta.
  2. Structured debug events - not metered and not hashed into the ledger, but included in tx meta.
  3. Debug events - metered, not hashed into the ledger, and not included in tx meta.

Contract and Structured debug events contain xdr::ContractEvents, while Debug events are just strings used for local development.

Some questions we need to answer -

  • Should Debug events not be metered?
  • If Debug events are not metered, do we combine with Structured debug events and just emit the string in the data field as a byte vector for the existing Debug events.
  • Instead of having events that are not metered, should we treat Structured debug events like Contract events by hashing them into the ledger and therefore including them into the protocol?
  • If we keep non-metered events, should they be put in a separate list from metered events for safety?
@graydon
Copy link
Contributor

graydon commented May 30, 2023

Done in #806

@graydon graydon closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants