Err reform #806
Merged
Err reform #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
err-reform
branch
10 times, most recently
from
c68cdce
to
8fd11b4
Compare
dmkozh
reviewed
May 15, 2023
graydon
force-pushed
the
err-reform
branch
3 times, most recently
from
cb01700
to
866572c
Compare
leighmcculloch
approved these changes
May 17, 2023
graydon
added a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
May 19, 2023
This is the companion PR to stellar/rs-soroban-env#806 (and stellar/rs-stellar-xdr#258 and stellar/stellar-xdr#92) overhauling error codes and renaming Status to Error.
This was referenced May 30, 2023
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch that's quite repetitive but ultimately fairly simple, that performs a variety of fixes related to events and errors. I think it's all stuff we've already agreed "needs to happen" and I figured I'd just try to get it all done this week while everyone else was away from keyboard.
Hopefully I'll be done soon but it's going to probably take another day or two of just grinding through errors. Here's basically what it covers:
StatustoError(the most-agreeable part of A bunch of simple renamings #689)DebugEvententirely, moving all diagnostics to structured-event form, answering at least some of Revisit diagnostic/debug event design #731I thought I'd post it for feedback early, in case anyone really hates the direction. I'm pretty keen on how it's turning out so far -- it seems like it really addresses a lot of the shortcomings we've identified so far and most of the churn is just obvious cleanup after the main structural changes -- but I'm interested to know if it looks to anyone like it's going the wrong direction.