Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch that's quite repetitive but ultimately fairly simple, that performs a variety of fixes related to events and errors. I think it's all stuff we've already agreed "needs to happen" and I figured I'd just try to get it all done this week while everyone else was away from keyboard.
Hopefully I'll be done soon but it's going to probably take another day or two of just grinding through errors. Here's basically what it covers:
Status
toError
(the most-agreeable part of A bunch of simple renamings #689)DebugEvent
entirely, moving all diagnostics to structured-event form, answering at least some of Revisit diagnostic/debug event design #731I thought I'd post it for feedback early, in case anyone really hates the direction. I'm pretty keen on how it's turning out so far -- it seems like it really addresses a lot of the shortcomings we've identified so far and most of the churn is just obvious cleanup after the main structural changes -- but I'm interested to know if it looks to anyone like it's going the wrong direction.