Use explicit protocol version for test Wasms. #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modified the makefile to regenerate Wasms in the directory corresponding to the necessary protocol version. I'm not sure yet if we need to maintain several versions of every Wasm, so I'm only leaving the v20 Wasms checked-in for now (I did try to generate v21 though just for a sanity check). Going forward I think we could keep explicitly versioned Wasms around for tests that need them, but otherwise have just a single version.
sisuresh
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Also modified the makefile to regenerate Wasms in the directory corresponding to the necessary protocol version.
I'm not sure yet if we need to maintain several versions of every Wasm, so I'm only leaving the v20 Wasms checked-in for now (I did try to generate v21 though just for a sanity check). Going forward I think we could keep explicitly versioned Wasms around for tests that need them, but otherwise have just a single version.
Why
Preparing for adding p22 tests that need different versions of Wasm (specifically, constructor tests).
Known limitations
N/A