Rounding improvement for budget model with iterations > 1
#1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
changed the title
jayz22
changed the title
iterations > 1
Co-authored-by: Siddharth Suresh <[email protected]>
yeah I'll mention that in the CAP |
graydon
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a simple improvement to the rounding of budget model evaluation, when the model is linear and iteration > 1.
Current: 1. evaluates the linear equation, 2. scale the result back, then 3. multiply by iteration.
This change: 1. evaluates the linear equation, 2. multiply by iteration 3. scale the result back.
The latter results in less rounding and better precision when the iteration count is large.
Also added a test to illustrated expected behavior.
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]