Prohibit using disjoint signatures to cover the auth tree. #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so require auth calls like A->B can't succeed if signatures for A and B are passed separately. This is achieved via requiring all the authorized calls to belong to some active root higher up the tree (if any). It is still possible to have multiple disjoint trees on behalf of the same address, but they must have their roots at the same call tree level.
sisuresh
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prohibit using disjoint signatures to cover the auth tree.
Also did a passing-by cleanup to not load the source account lazily. We should have source account available in relevant contexts that use enforcing auth.
Why
This makes it so require auth calls like A->B can't succeed if signatures for A and B are passed separately. This is achieved via requiring all the authorized calls to belong to some active root higher up the tree (if any).
It is still possible to have multiple disjoint trees on behalf of the same address, but they must have their roots at the same call tree level.
Known limitations
N/A