Skip to content

Commit

Permalink
Revert downgrading of log error->warn->error
Browse files Browse the repository at this point in the history
Add more guidance to CheckSingleLedgerHeaderWork failure case to assure operators this is not a fatal error, advises them to notify operator of faulty archives is issue persist
  • Loading branch information
ThomasBrady committed Oct 22, 2024
1 parent f29b9f1 commit 4343f4b
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/historywork/CheckSingleLedgerHeaderWork.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,16 @@ CheckSingleLedgerHeaderWork::doWork()
}
else if (mGetLedgerFileWork->getState() != State::WORK_SUCCESS)
{
CLOG_WARNING(History,
"Failed to download ledger checkpoint {} from archive {}",
mFt->baseName_gz(), mArchive->getName());
CLOG_ERROR(
History,
"Failed to download ledger checkpoint {} from archive {}. This may "
"be due to transient network issues, or the archive may be missing "
"the checkpoint. stellar-core will try to download the file from "
"another archive. This error *does not* necessarily require a "
"configuration change to remove the archive. If you repeatedly see "
"this error, please notify the operator of the archive that you "
"are observing gaps.",
mFt->baseName_gz(), mArchive->getName());
return mGetLedgerFileWork->getState();
}

Expand Down

0 comments on commit 4343f4b

Please sign in to comment.