Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean RUST_TARGET_DIR when soroban rlibs change #4510

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Oct 21, 2024

It seems -- I'll use "seems" here because I am not 100% certain but this is congruent with my observations of errors so far -- that rustc and/or cargo don't do a good job of tracking the dependency of librust_stellar_core.a on the manually-provided soroban rlibs: that recompiling the soroban rlibs causes us to trigger a rebuild of librust_stellar_core.a but cargo and/or rustc frequently decides that "nothing changed in its dependencies" and so doesn't actually do any recompiling. Which means we can wind up with stale soroban bits in librust_stellar_core.a.

(It also "seems" like the stamp-file time tracking based on touch isn't reliably triggering a rebuild; this seems like it should never be true since touch alters mtime which is all that make tracks, but I think I observed such a failure during debugging and it's harmless to remove-and-recreate the stamp-file just to be sure.)

@graydon graydon added this pull request to the merge queue Oct 22, 2024
Merged via the queue into stellar:master with commit 12c3f77 Oct 22, 2024
13 checks passed
@graydon graydon deleted the makefile-fixes branch October 22, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants