[system-health] delay system-health service start #129
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
reviewed
Nov 11, 2024
| Description=Delays SONiC system health monitor until SONiC has started | ||
|
|
||
| [Timer] | ||
| OnBootSec=1min 30 sec |
There was a problem hiding this comment.
Please don't introduce a timer. Instead can you make sure its event based?
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
force-pushed
the
delay-system-health
branch
from
4355c85 to
e415a82
Compare
dgsudharsan
approved these changes
Nov 12, 2024
Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To improve boot time and stabilize boot time as well as fast-reboot downtime consistency.
Work item tracking
How I did it
Delay system-health daemon till boot is finished, same as other daemons.
How to verify it
Boot the system, verify system-health service starts with a delay, execute command:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)