-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifying JSON read code #1449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added escape_unicode.hpp
sjanel
reviewed
Nov 22, 2024
@@ -30,7 +30,11 @@ namespace glz | |||
constexpr string_literal& operator=(const string_literal&) noexcept = default; | |||
constexpr string_literal& operator=(string_literal&&) noexcept = default; | |||
|
|||
constexpr string_literal(const char (&str)[N]) noexcept { std::copy_n(str, N, value); } | |||
constexpr string_literal(const char (&str)[N]) noexcept { | |||
for (size_t i = 0; i < N; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to avoid include of <algorithm>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjanel, yes I'm slowly trying to remove large header includes where they aren't really necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change for escaped unicode keys
Removed the option
escaped_unicode_key_conversion
, as it added significant complexity to the underlying code and required inefficient parsing due to heap allocations and resulted in inefficient hashing. Removing this option does not break any JSON conformance.If you require both unescaped and escaped versions for a key, then register both of these keys with the same member pointer within
glz::meta
. This gives far better performance, but should still generally be avoided.Added "glaze/json/escape_unicode.hpp", which provides
glz::escape_unicode
. This results in a compile time escaped version of the input string.An example: