-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fix for range operator #19
base: master
Are you sure you want to change the base?
Conversation
I want to take this, but I don't know what's going to happen now when parsing something like Also the reformatting of code makes this too big of a PR for me to go through. Unfortunately not really much automation/unti testing available to confirm nothing was broken with such aggressive refactor, that's my fault not yours, but makes it hard for me to merge this with any confidence. |
can you authorize me to add a better test system (eg not literate coffee and not tape) ? |
Yeah I don't have much time to work on this project anymore (or at the moment anyway). But I'll accept PRs for any unit tests or a fix to the range issue. I do appreciate the work but it would be hard for me to accept the style refactoring that you did. thanks! |
Just out of curiosity, can you explain me what is your influences for this non standard code style ? |
ok for "Comma First" but why you declare function as
I agree with this 😉 |
I have remove the style refactoring. |
Oh you're right, you know, I think I was just trying some new things style-wise that I don't get to do at work. We can change the style -- I'm not married to it. How do you feel about StandardJS? I use |
any progress on this? This pretty much makes it useless for me. |
Just remove the forced error on
..
Fix #17