Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for range operator #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ldez
Copy link

@ldez ldez commented Apr 7, 2017

Just remove the forced error on ..

Fix #17

@sterpe
Copy link
Owner

sterpe commented Apr 7, 2017

I want to take this, but I don't know what's going to happen now when parsing something like [1..7]. In theory, removing the error is good, but what happens to the whole token stream after that point?

Also the reformatting of code makes this too big of a PR for me to go through. Unfortunately not really much automation/unti testing available to confirm nothing was broken with such aggressive refactor, that's my fault not yours, but makes it hard for me to merge this with any confidence.

@ldez
Copy link
Author

ldez commented Apr 7, 2017

can you authorize me to add a better test system (eg not literate coffee and not tape) ?

@sterpe
Copy link
Owner

sterpe commented Apr 8, 2017

Yeah I don't have much time to work on this project anymore (or at the moment anyway). But I'll accept PRs for any unit tests or a fix to the range issue. I do appreciate the work but it would be hard for me to accept the style refactoring that you did.

thanks!

@ldez
Copy link
Author

ldez commented Apr 8, 2017

Just out of curiosity, can you explain me what is your influences for this non standard code style ?

@sterpe
Copy link
Owner

sterpe commented Apr 8, 2017

@ldez
Copy link
Author

ldez commented Apr 8, 2017

ok for "Comma First" but why you declare function as var instead of named function and why you declare all variables in the top of file ?

npm's coding style is a bit unconventional.

I agree with this 😉

@ldez
Copy link
Author

ldez commented Apr 8, 2017

I have remove the style refactoring.

@sterpe
Copy link
Owner

sterpe commented Apr 8, 2017

Oh you're right, you know, I think I was just trying some new things style-wise that I don't get to do at work. We can change the style -- I'm not married to it. How do you feel about StandardJS? I use standard for pretty much all newer stuff I've been writing...plus they have an auto reformatter.

https://standardjs.com

@UziTech
Copy link

UziTech commented Aug 11, 2017

any progress on this? This pretty much makes it useless for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants