Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure int values of boxlength are converted to floats #67

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

DanielaBreitman
Copy link
Collaborator

When I input an int value of boxlength to get_power I get a very different (and wrong) power spectrum.
We should just include all the input types for all functions, but in the meantime, I added a quick fix where 0.0 is added to the boxlength to make sure it is a float.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (089bf2e) to head (b807871).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   92.86%   92.88%   +0.01%     
==========================================
  Files           5        5              
  Lines         575      576       +1     
==========================================
+ Hits          534      535       +1     
  Misses         41       41              
Flag Coverage Δ
unittests 92.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielaBreitman. The preferred way to get float-type values is to use the float(val) syntax, which is also more explicit, so let's use that.

@steven-murray steven-murray merged commit bcf2573 into main Aug 2, 2024
27 checks passed
@steven-murray steven-murray deleted the fix_boxlength branch August 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants