-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the phone screen leaflet exit animation #20
base: main
Are you sure you want to change the base?
Conversation
@azaek is attempting to deploy a commit to the Elegance Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for the PR! Just checking this out – it seems like it's still not working? CleanShot.2023-01-19.at.11.00.05.mp4 |
Weird I have literally the same code in another project and it works 😶. I'm gonna look more |
Update on the issue: AnimatePresence doesn't trigger the exit animation if the dialog components are used from hooks. If you use the base dialog component without it works fine. |
@azaek whoa interesting! So in this case you can't use the Leaflet component from within a hook? Sounds kinda odd – would it be a bug on Framer Motion's side? |
Yea it's very odd. I guess it's from Framer Motion's side, I raised a bug issue there. Let's see |
Awesome, thank you so much @azaek! Can you link to the issue here? |
Exit animation weren't working properly due to 2
AnimatePresence
wrap