Observed generation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ql-action-digest Update github/codeql-action digest to 49abf0b
…duplicate-actions-5.x Update fkirc/skip-duplicate-actions action to v5.3.1
Signed-off-by: Philippe Scorsolini <[email protected]>
* Bump crossplane-runtime * Update GetInteger to handle floats locally * Use new claim.Reference type Signed-off-by: Steven Borrelli <[email protected]>
…deps Update module sigs.k8s.io/yaml to v1.4.0
…crossplane-crossplane-runtime-1.x Update module github.com/crossplane/crossplane-runtime to v1.14.0-rc.1
…y-trivy-action-0.x Update aquasecurity/trivy-action action to v0.13.0
Notably this includes a handy new linter that warns when you don't use GetFoo methods to access protobuf fields. Signed-off-by: Nic Cope <[email protected]>
Bump golangci-lint to v1.55.1
…ql-action-digest Update github/codeql-action digest to 74483a3
Signed-off-by: Nic Cope <[email protected]>
This is necessary for functions to be able to return JSON (as structpb.Struct) that can be used as server side apply fully specified intent. Without it we include empty structs that are non-nil, even if they have the omitempty marker. Signed-off-by: Nic Cope <[email protected]>
I don't love the package-scoped state here but this seems like the nicest API to offer callers. Signed-off-by: Nic Cope <[email protected]>
Marshal MR structs in a (more) server-side apply compatible way
Without this change any resource that has no ObjectMeta will end up with
an empty metadata (like "metadata": {}) when rendered. This is because
json serialization adds the generation field. We then delete it,
resulting in an empty metadata object.
This isn't actually so bad because Crossplane will always add a few
labels, owner refs, etc before the metadata becomes part of the SSA
fully-specified intent. So in reality we'll never ask the API server to
make metadata an empty object. It is misleading in unit tests though.
Signed-off-by: Nic Cope <[email protected]>
Clear out empty object metadata if it exists after conversion
…om/docker/docker-vulnerability Update module github.com/docker/docker to v24.0.7+incompatible [SECURITY]
…bufbuild-buf-1.x Update module github.com/bufbuild/buf to v1.27.2
Update dependency golang to v1.21.6
This is mostly useful when a function loads its input from the RunFunctionRequest. Crossplane isn't (yet) aware of input schema and will send anything the user supplies. Right now that could include extra unknown, misindented, or typod fields and those will be silently ignored by the function. With this change in place they will result in an error. This code will also be used to load desired and observed resource state, but it's unlikely for those to be invalid. This is a small behavior change, but I feel okay with it. The new behavior is safer, probably won't affect anyone, and we're pre 1.0. crossplane-contrib/function-patch-and-transform#91 (comment) Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
…-bufbuild-buf-1.x Update module github.com/bufbuild/buf to v1.29.0
Reject unknown fields when converting from Struct to Object
…go-json-experiment-json-digest Update github.com/go-json-experiment/json digest to 2e55bd4
…eql-action-3.x
Fix error formatting for GetInput
…che-4.x Update actions/cache action to v4
…com/docker/docker-vulnerability
Signed-off-by: Philippe Scorsolini <[email protected]>
…-bufbuild-buf-1.x Update module github.com/bufbuild/buf to v1.30.0
…decov-action-digest Update codecov/codecov-action digest to 8450866
…org/x/net-vulnerability
Signed-off-by: Nic Cope <[email protected]>
Switch to crossplane/build
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds 1.16's observedGeneration