Add button style reset code in case the user forgets to do so. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user does not reset the default browser styling for buttons, the next and previous buttons will be ugly, because they will have shadows drawn right through the buttons.
The fact that this happens violates the principle of least astonishment, especially for Rails users who expect to be done after adding colorbox-rails to the Gemfile. And even more so if the Rails user is not a CSS guru :-)
This post pointed me in the right direction: http://community.sitepoint.com/t/gray-borders-around-controls-in-colorbox/27750
This pull request fixes the aestetics for sites that do not reset button shadows wholesale.