(Closes #2768) Improve robustness of Sign2Code and Abs2Code transformations #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st arg to SIGN [skip ci]
|
|
arporter
added
PSyIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the target of the transformation has a scalar argument of known type (previously we were very naughty and assumed it was a REAL scalar). In order to allow us to seamlessly support arguments of integer type, I've extended the Fortran backend for Literals slightly so that it now ensures that reals end in ".0" and doubles in ".0d0". This revealed a bug in PSyAD where we were declaring array indices as REAL rather than INTEGER.