ENH: setup dependencies.json #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having a separate dependencies file makes it easier for us to update versions and potentially use dependabot or something similar for this repo
meoflynn
requested changes
Oct 16, 2024
dependencies.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "capo-addon-version": "0.5.9", | |||
| "capo-provider-version": "v0.10.4", | |||
There was a problem hiding this comment.
Could we update the capo provider version to v0.11.0 ?
There was a problem hiding this comment.
cluster api provider openstack - CAPO is v0.10.5 - https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases/tag/v0.10.5 - i'll update that and the addon-version which should be 0.7.0
if you're referring to azimuth-cloud/capi-helm-charts chart version - users should automatically use the most up-to-date chart when they follow our docs
There was a problem hiding this comment.
Ah I got the variables mixed up with what they refer to 😅
meoflynn
reviewed
Oct 16, 2024
addon-provider 0.7.0 capo - 0.10.5
anish-mudaraddi
force-pushed
the
setup-dep-file
branch
from
a581471
to
b41ddf0
Compare
meoflynn
reviewed
Oct 16, 2024
dependencies.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "capo-addon-version": "0.7.0", | |||
There was a problem hiding this comment.
could we change this variable name slightly? e.g aziumuth-capo-addon?
gmatthews20
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having a separate dependencies file makes it easier for us to update versions and potentially use dependabot or something similar for this repo