-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #445) upgrade to v4 of codecov action and supply token #446
Conversation
I've added the CodeCov token to the list of 'secrets' for this repo. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 85 85
Lines 13678 13678
=======================================
Hits 12583 12583
Misses 1095 1095 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter I am fine with the update to v4 but note that this does not fix the status check issue and still requires a merge without waiting to met the requirements. Note that v3 already provided report comments, so this doesn't change the behaviour. Should we try to fix it in this PR? But if you want this on master first I will be happy to approve.
Thanks @sergisiso. I've googled and can find nothing to suggest we're doing anything wrong. Before this patch, uploads to CodeCov were failing with a 'missing token' error. This at least fixes that. I've looked at the CodeCov github app and that seems fine. The upload to CodeCov is fine. It just seems that CodeCov is not then reporting back to GitHub, possibly because it says it's missing coverage for the base commit. Therefore, I think this can go on as it is a small improvement over what we currently have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks @arporter, this is approved for merging.
No description provided.