Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #445) upgrade to v4 of codecov action and supply token #446

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

arporter
Copy link
Member

No description provided.

@arporter
Copy link
Member Author

I've added the CodeCov token to the list of 'secrets' for this repo.
Upload to CodeCov was performed successfully (although CodeCov is still not happy because there's no coverage report for the base commit of this PR). Landing page now has a pretty picture :-)
Ready for review from @sergisiso or @hiker.

@arporter arporter self-assigned this Apr 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (a9ea1e9) to head (b98307d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          85       85           
  Lines       13678    13678           
=======================================
  Hits        12583    12583           
  Misses       1095     1095           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arporter arporter changed the title #445 upgrade to v4 of action and supply token (Closes #445) upgrade to v4 of codecov action and supply token Apr 22, 2024
Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter I am fine with the update to v4 but note that this does not fix the status check issue and still requires a merge without waiting to met the requirements. Note that v3 already provided report comments, so this doesn't change the behaviour. Should we try to fix it in this PR? But if you want this on master first I will be happy to approve.

@sergisiso sergisiso added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Apr 23, 2024
@arporter
Copy link
Member Author

Thanks @sergisiso. I've googled and can find nothing to suggest we're doing anything wrong. Before this patch, uploads to CodeCov were failing with a 'missing token' error. This at least fixes that. I've looked at the CodeCov github app and that seems fine. The upload to CodeCov is fine. It just seems that CodeCov is not then reporting back to GitHub, possibly because it says it's missing coverage for the base commit. Therefore, I think this can go on as it is a small improvement over what we currently have.

@sergisiso sergisiso removed the reviewed with actions PR has been reviewed and is back with developer label Apr 23, 2024
Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks @arporter, this is approved for merging.

@sergisiso sergisiso added the ready for merge PR is waiting on final CI checks before being merged. label Apr 23, 2024
@sergisiso sergisiso merged commit 1259f8a into master Apr 23, 2024
4 checks passed
@sergisiso sergisiso deleted the 445_codecov_update branch April 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants