Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #320) nonstandard stop #451

Merged
merged 12 commits into from
Oct 14, 2024
Merged

(Closes #320) nonstandard stop #451

merged 12 commits into from
Oct 14, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Oct 2, 2024

Fixes #320. Adds support for extended stop codes to Fortran 2003, and adds full 2008 support for (even more) flexible expressions.

I hope I did the 2008 part correctly. I esp. wasn't certain how to check if the expressions are constant :(

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (55db863) to head (17a1078).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   92.13%   92.14%           
=======================================
  Files          85       86    +1     
  Lines       13824    13834   +10     
=======================================
+ Hits        12737    12747   +10     
  Misses       1087     1087           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this Joerg. Generally all looks good but I'd like a couple more tests to show that parsing STOP statements works in the context of a full parse and that the extension can be switched off. I'd also like some tests to show that the F2003 forms are still accepted by the F2008 parser.
Updated docs build fine (modulo the hundreds of existing warnings) and look good.

doc/source/fparser2.rst Outdated Show resolved Hide resolved
src/fparser/two/utils.py Outdated Show resolved Hide resolved
src/fparser/two/tests/test_fortran2003.py Show resolved Hide resolved
src/fparser/two/tests/test_fortran2003.py Outdated Show resolved Hide resolved
src/fparser/two/Fortran2008/stop_code_r857.py Show resolved Hide resolved
@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Oct 7, 2024
@hiker
Copy link
Collaborator Author

hiker commented Oct 11, 2024

Ready for next review.

@hiker hiker added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Oct 11, 2024
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending those tests Joerg. All good now. I've tested it with the PSyclone test suite and all is fine.
There are couple of bits of tidying needed but as that's just an import statement I'll do that.

@arporter arporter added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Oct 14, 2024
@arporter arporter changed the title 320 nonstandard stop (Closes #320) nonstandard stop Oct 14, 2024
@arporter arporter merged commit 84a4b1d into master Oct 14, 2024
6 checks passed
@arporter arporter deleted the 320_nonstandard_stop branch October 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing executable-constructs in F2008 (R213)
2 participants