Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added animation instead of redraw #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bpinaya
Copy link

@bpinaya bpinaya commented Mar 19, 2015

Hi there friend! So I really loved your gauge but I didn't liked the remove and then redraw again part. So This is my change, there is one more attribute for configuration: transitionMs . That is the delay in the transition of the gauge. Everything else is quite the same since I really enjoyed the component. Best regards!
Ben

@bpinaya
Copy link
Author

bpinaya commented Mar 19, 2015

*That is the delay in the transition of the needle

@stherrienaspnet
Copy link
Owner

Thank you very much for your change, I will merge them this weekend!
On Mar 19, 2015 6:22 PM, "Benjamin Pinaya" [email protected] wrote:

Hi there friend! So I really loved your gauge but I didn't liked the
remove and then redraw again part. So This is my change, there is one more
attribute for configuration: transitionMs . That is the delay in the
transition of the gauge. Everything else is quite the same since I really
enjoyed the component. Best regards!

Ben

You can view, comment on, or merge this pull request online at:

#4
Commit Summary

  • animations and some changes

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#4.

@stherrienaspnet
Copy link
Owner

Benjamin, I made a mistake last time I gave you the wrong repository. Could
you bring your change to repository ngRadialGauge if you have time because
this is the repository, I will always use.

Thanks you,
Stephane:)
On Mar 19, 2015 6:22 PM, "Benjamin Pinaya" [email protected] wrote:

Hi there friend! So I really loved your gauge but I didn't liked the
remove and then redraw again part. So This is my change, there is one more
attribute for configuration: transitionMs . That is the delay in the
transition of the gauge. Everything else is quite the same since I really
enjoyed the component. Best regards!

Ben

You can view, comment on, or merge this pull request online at:

#4
Commit Summary

  • animations and some changes

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#4.

@bpinaya
Copy link
Author

bpinaya commented Mar 19, 2015

Sure! Will do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants