Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swish 2 #600

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Swish 2 #600

merged 6 commits into from
Aug 7, 2023

Conversation

adamalfredsson
Copy link
Collaborator

Some modifications to integrate properly with the frontend. The swish order ID is returned when creating a donation, which the frontend will then use to poll the status of the swish payment.


Tested on devices

  • Desktop 💻
  • Mobile 📱

Tests

  • All tests are running ✔️
  • Test are updated 🧪
  • Code Review 👩‍💻
  • QA 👌

Checkpoints

Check these to flag for a more thurough review, as they could be potentially breaking changes

  • Packages updated
  • Other infrastructure updated (such as node version or similar)

⏲️ Time spent on CR:

⏲️ Time spent on QA:

@adamalfredsson
Copy link
Collaborator Author

Check fails due to #603

Copy link
Member

@fellmirr fellmirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

The only thing I can spot is the swagger thing, if I'm right about that :) Otherwise looks good to go.

src/__test__/swish.spec.ts Show resolved Hide resolved
src/custom_modules/swish.ts Show resolved Hide resolved
src/routes/swish.ts Outdated Show resolved Hide resolved
@adamalfredsson
Copy link
Collaborator Author

Fails test due to missing EFFEKT_API_URL environment variable

Copy link
Member

@fellmirr fellmirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@fellmirr fellmirr merged commit e898bb7 into master Aug 7, 2023
2 checks passed
@fellmirr fellmirr deleted the feature/swish-2 branch August 7, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants