Feature/removing lodash #4

guillaumebriday · 2023-12-22T05:33:42Z

Fix https://github.com/stimulus-components/stimulus-scroll-progress/issues/3

florentdestremau · 2023-12-22T09:17:05Z

src/index.ts

 import { Controller } from '@hotwired/stimulus'
-import { throttle } from 'lodash'
+import { throttle } from './utils'



I think it would be even simpler to have the trigger declared inside the file (again, in the case of an import map, it's best not to expand unnecessarily across several files).

~~I got it, but I also don't want to architecture the project just for import-maps and I guess it's completely fine to load this really small file~~

~~Removing lodash will make a huge difference 👍 ~~

I didn't know but vite imported the file itself directly in the .mjs file so there is no issue for you

Removing lodash

89b28d5

guillaumebriday force-pushed the feature/removing-lodash branch from 66dfa69 to 89b28d5 Compare December 22, 2023 05:34

florentdestremau reviewed Dec 22, 2023

View reviewed changes

guillaumebriday merged commit f344520 into master Dec 24, 2023
3 of 4 checks passed

guillaumebriday deleted the feature/removing-lodash branch December 24, 2023 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/removing lodash #4

Feature/removing lodash #4

guillaumebriday commented Dec 22, 2023

florentdestremau Dec 22, 2023

guillaumebriday Dec 24, 2023 •

edited

Loading

Feature/removing lodash #4

Feature/removing lodash #4

Conversation

guillaumebriday commented Dec 22, 2023

florentdestremau Dec 22, 2023

Choose a reason for hiding this comment

guillaumebriday Dec 24, 2023 • edited Loading

Choose a reason for hiding this comment

guillaumebriday Dec 24, 2023 •

edited

Loading