Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subghz: Allow custom lora sync word #383

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

huming2207
Copy link
Contributor

Hi @newAM

Firstly thanks again for your great effort for this library!

We are trying to use this library to implement a factory testing firmware for our LoRa products. The current implementation doesn't allow us to configure custom LoRa sync word, so our LoRa protocol won't work. Therefore I implemented this feature to make it fit to our use cases.

Regards,
Jackson

@newAM
Copy link
Member

newAM commented Aug 20, 2024

Oh boy, CI really hasn't been run in a while. I'll take a look at that this weekend.

@huming2207
Copy link
Contributor Author

In regards to the changes, I'm also thinking to add a few more From<&[u8]> impls to those LoRa/GFSK config structs. For example imagine I've got a From<&[u8]> that allows let pkt_params = LoRaPacketParams::from(some_slice); so that I can pass pre-serialised config data over UART or SWD into the target for testing.

Are you interested? If yes then I will also push a separate PR. @newAM

@huming2207
Copy link
Contributor Author

huming2207 commented Sep 2, 2024

@newAM any updates on this...?

edit: sorry I didn't see your latest commits on CI... I will wait you finish that first.

@newAM
Copy link
Member

newAM commented Sep 2, 2024

No worries! Can you update this branch? Then CI should start to work again.

@huming2207
Copy link
Contributor Author

No worries! Can you update this branch? Then CI should start to work again.

It should work now.

@newAM newAM added this pull request to the merge queue Sep 6, 2024
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay, work has been crazy lately.

Merged via the queue into stm32-rs:main with commit ab9b9ca Sep 6, 2024
16 checks passed
@huming2207
Copy link
Contributor Author

@newAM thanks!

In regards to the changes, I'm also thinking to add a few more From<&[u8]> impls to those LoRa/GFSK config structs. For example imagine I've got a From<&[u8]> that allows let pkt_params = LoRaPacketParams::from(some_slice); so that I can pass pre-serialised config data over UART or SWD into the target for testing.

Also I would like to know are you interested in more PRs? For example the STOP2 low power mode, LPUART's FIFO mode, and these From<&[u8]> stuff mentioned above?

I need the STOP1/STOP2 mode to work in my project, and I'm also keen on do some researches on LPUART FIFO mode.

@newAM
Copy link
Member

newAM commented Sep 6, 2024

Yeah! I'm definitively interested in more PRs, it just may take me a while to get to them :)

@huming2207
Copy link
Contributor Author

Great, will do later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants