[ACM-15010] Added error condition for invalid client id

[dislbenn]

Description

When a user has an invalid client ID, the discovery-operator is not removing any DiscoveredCluster resources from the console. This PR will add a new error condition for a invalid_client and remove any DiscoveredCluster resource from the cluster.

2024-10-23T14:24:44.803Z ERROR reconcile Error updating DiscoveredClusters {"error": "couldn't get token: &{401 invalid_client Invalid client or Invalid client credentials <nil> []}"}

Related Issue

https://issues.redhat.com/browse/ACM-15010

Changes Made

Added new error condition for invalid_client.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

• I have tested the changes locally and they are functioning as expected.
• I have updated the documentation (if necessary) to reflect the changes.
• I have added/updated relevant unit tests (if applicable).
• I have ensured that my code follows the project's coding standards.
• I have checked for any potential security issues and addressed them.
• I have added necessary comments to the code, especially in complex or unclear sections.
• I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

• Code is reviewed.
• Code is tested.
• Documentation is updated.
• All checks and tests pass.
• Approved by at least one reviewer.
• Merged into the main/master branch.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dislbenn]

/retest

[dislbenn]

/cherry-pick backplane-2.7

[openshift-cherrypick-robot]

@dislbenn: once the present PR merges, I will cherry-pick it on top of backplane-2.7 in a new PR and assign it to you.

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cameronmwall]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dislbenn]

/cherry-pick backplane-2.7

[openshift-cherrypick-robot]

@dislbenn: new pull request created: #481

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.