chore: allow release-plz to open changelog PRs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- grant permissions to open PRs and add changelogs, needed for release-please to do the thing - run check and test in parallel. no need to have tests wait for lints. see: https://github.com/google-github-actions/release-please-action/issues/709 License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
commented
Nov 20, 2023
| @@ -17,11 +17,9 @@ jobs: | |||
| node-version: 18 | |||
| cache: 'npm' | |||
| - run: npm ci | |||
| - run: npm run build | |||
There was a problem hiding this comment.
build is redundant here, now we call it from prepare it happens as part of npm ci
olizilla
commented
Nov 20, 2023
| - run: npm run lint | ||
|
|
||
| test: | ||
| needs: check |
There was a problem hiding this comment.
we can run check and test in parallel.
olizilla
commented
Nov 20, 2023
Comment on lines
+45
to
+46
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
hoping it fix like https://github.com/google-github-actions/release-please-action/issues/709
alanshaw
approved these changes
Nov 20, 2023
olizilla
pushed a commit
that referenced
this pull request
Nov 20, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.2](v1.0.1...v1.0.2) (2023-11-20) ### Bug Fixes * handle paths as string param ([#29](#29)) ([fa7dcf0](fa7dcf0)) * #28 ([fa7dcf0](fa7dcf0)) ### Other Changes * allow release-plz to open changelog PRs ([#31](#31)) ([350c916](350c916)) * release from ci and add `--provenance` for verifiable builds! ([#30](#30)) ([7ae47f4](7ae47f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hoping this fixes the error seen here where release please is unable to open a PR
https://github.com/web3-storage/files-from-path/actions/runs/6932934315/job/18858238223
see: https://github.com/google-github-actions/release-please-action/issues/709
License: MIT