Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: publish from dist #33

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: publish from dist #33

merged 1 commit into from
Nov 29, 2023

Conversation

alanshaw
Copy link
Member

ipjs build copies everything needed (including package.json) into dist directory.

olizilla
olizilla approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get the quick fix, but the build in this repo is too clever for it's own good.

I'm sure we needed all that ceremony once, but I think we can simplify it now.

@alanshaw
Copy link
Member Author

+1 yes it can be ESM only now I think.

@alanshaw alanshaw merged commit fea9816 into main Nov 29, 2023
6 checks passed
@alanshaw alanshaw deleted the fix/publish-from-dist branch November 29, 2023 11:54
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Merged
alanshaw pushed a commit that referenced this pull request Nov 29, 2023
@github-actions
chore(main): release 1.0.3 (#34)
ceb5745 
🤖 I have created a release *beep* *boop*
---


##
[1.0.3](v1.0.2...v1.0.3)
(2023-11-29)


### Bug Fixes

* publish from dist
([#33](#33))
([fea9816](fea9816))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @olizilla