Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Add new build stage in CI #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darkowlzz
Copy link
Contributor

This adds a new build stage in the CI where the container image is built
once and pushed to docker hub. The test and deploy stages pull the same
image and use it.

New docker hub repo:
https://hub.docker.com/r/stosci/cluster-operator

This adds a new build stage in the CI where the container image is built
once and pushed to docker hub. The test and deploy stages pull the same
image and use it.

New docker hub repo:
https://hub.docker.com/r/stosci/cluster-operator
Copy link
Contributor

@croomes croomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the pipline passes

@darkowlzz darkowlzz removed the request for review from domodwyer September 6, 2019 09:12
@darkowlzz
Copy link
Contributor Author

darkowlzz commented Sep 6, 2019

TravisCI env vars are not shared with pull requests from forks. The same is true for the encrypted variables https://docs.travis-ci.com/user/environment-variables/#defining-encrypted-variables-in-travisyml . We may not be able to make this work.
Using a publicly open image registry is risky when the tagged release is also pushed there and pulled for final release. We can add a conditional workaround for that. I'm still looking for a way to make this work without the security risks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants