Check a node is either cordoned or compute-only when moving (#224)

Add a few extra checks so we don't let users move volumes into either
cordoned or compute-only nodes.

cmd/update/volume_move.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"strconv"
 	"time"
 
 	"github.com/spf13/cobra"
@@ -49,6 +50,10 @@ func (c *volumeMoveCommand) runWithCtx(ctx context.Context, cmd *cobra.Command,
 
 	nsID := id.Namespace(c.namespace)
 
+	// look into the node config and its labels so we know whether we are
+	// attempting to move to a node that is marked as compute-only, etc
+	var toNodeCfg *model.Node
+
 	if !useIDs {
 		ns, err := c.client.GetNamespaceByName(ctx, c.namespace)
 		if err != nil {
@@ -62,11 +67,29 @@ func (c *volumeMoveCommand) runWithCtx(ctx context.Context, cmd *cobra.Command,
 		}
 		c.fromNode = fromNode.ID.String()
 
-		toNode, err := c.client.GetNodeByName(ctx, c.toNode)
+		toNodeCfg, err = c.client.GetNodeByName(ctx, c.toNode)
+		if err != nil {
+			return err
+		}
+		c.toNode = toNodeCfg.ID.String()
+	} else {
+		toNodeCfg, err = c.client.GetNode(ctx, id.Node(c.toNode))
 		if err != nil {
 			return err
 		}
-		c.toNode = toNode.ID.String()
+	}
+
+	if toNodeCfg.Cordoned {
+		return fmt.Errorf("cannot move volume into cordoned node")
+	}
+	if val, ok := toNodeCfg.Labels[model.LabelComputeOnly]; ok {
+		isComputeOnly, err := strconv.ParseBool(val)
+		if err != nil {
+			return fmt.Errorf("failed to parse compute-only label")
+		}
+		if isComputeOnly {
+			return fmt.Errorf("cannot move volume into compute-only node")
+		}
 	}
 
 	vol, err := c.getVolume(ctx, nsID)
@@ -184,6 +207,7 @@ A default timeout of 30min is in place but it should be adjusted with the global
 			err = c.client.SetReplicas(ctx, nsID, vol.ID, uint64(originalReplicaCount), setReplicasParam)
 			if err != nil {
 				c.display.TextMessage(ctx, c.writer, fmt.Sprintf("Failed to restore original replica count: %s. Can be addressed manually or wait for it to be re-synced with PVC.", err.Error()))
+				return
 			}
 
 			c.display.TextMessage(ctx, c.writer, "Restored volume original replica count.")

model/volume.go

@@ -23,7 +23,8 @@ const (
 	LabelReplicas = "storageos.com/replicas"
 	// LabelThrottle is a StorageOS volume label which when enabled deprioritises
 	// the volume's traffic by reducing disk I/O rate.
-	LabelThrottle = "storageos.com/throttle"
+	LabelThrottle    = "storageos.com/throttle"
+	LabelComputeOnly = "storageos.com/computeonly"
 )
 
 // FsType indicates the kind of filesystem which a volume has been given.