Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add player activity in sidebar + move ranks #37

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Add player activity in sidebar + move ranks #37

merged 2 commits into from
Feb 7, 2024

Conversation

robertvanhoesel
Copy link
Contributor

  • Uses the new players/{id}/statistics/activity endpoint
  • Simple pun chart activity view with win rates
  • Move ranks to sidebar
  • Some responsive changes in layout to accommodate sidebar
image

qlemaire22
qlemaire22 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@qlemaire22 qlemaire22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

src/pages/players/[id]-[username].astro Outdated Show resolved Hide resolved
@robertvanhoesel robertvanhoesel merged commit 66aee39 into main Feb 7, 2024
1 check passed
@robertvanhoesel robertvanhoesel deleted the pr/player-activity branch February 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlemaire22 qlemaire22 qlemaire22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertvanhoesel @qlemaire22