Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lighthouse SEO and A11y Rating #66

Merged

Conversation

KevSlashNull
Copy link
Contributor

This PR improves the SEO and accessibility score in the Lighthouse rating for the index page.

It mostly just adds alt tags to the images used on the index page but also an aria-label and texts only for screen readers.

The accessibility is not on 100% because your brand color/#f6005c doesn‘t have enough contrast with the white background:

image

Relates to #49. The performance on www.stormkit.io seems to be worse than in my test env, possibly because of tawk and GTM, or my older MacBook Air. 🤷

Screenshots

Before After
Screenshot image image
Scores Performance: 29, A11y: 73, Best Pract.: 100, SEO: 89 ∆Performance: 0, ∆A11y: +25, ∆Best Pract.: 0, ∆SEO: +11

Both tests were done in the dev environment, however, the performance increased to 98 when pre-building resources and serving via `yarn start. Also, the other scores did not change.

LH report with pre-built resources lighthouse scores

@stormkit-io
Copy link

stormkit-io bot commented Oct 21, 2020

Deployment completed

This pull request was successfully built on Stormkit. You can preview it using the following link.

https://stormkit-20328112256009.stormkit.dev

Copy link
Contributor

@svedova svedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow Kev you're everywhere :)) This is amazing, thanks a lot for the help 💯 🥇

@KevSlashNull KevSlashNull force-pushed the 49-Improve-SEO-and-A11y-LH-Rating branch from b793ebb to bfc86b6 Compare October 21, 2020 10:25
@svedova svedova merged commit 34b6485 into stormkit-io:master Oct 21, 2020
@KevSlashNull KevSlashNull deleted the 49-Improve-SEO-and-A11y-LH-Rating branch October 21, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants