Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new package structure with src dir, vitest, deps updates, revamped actions and more #1016

Merged
merged 24 commits into from
Dec 12, 2024

Conversation

dipankarmaikap
Copy link
Contributor

This PR introduces a new structure and multiple improvements, including:

  • Moved to src directory instead of lib.
  • Refactored project under pnpm workspaces.
  • Cypress config and folder moved to root.
  • Default E2E runs against playground/test (more coverage needed).
  • Added Vitest function tests (more tests needed).
  • Updated GitHub Actions with commitlint and separate workflows for lint/test.
  • Upgraded dependencies (no breaking changes to SDK).

@dipankarmaikap dipankarmaikap changed the title Chore: new package structure with src dir, vitest, deps updates, revamped actions and more chore: new package structure with src dir, vitest, deps updates, revamped actions and more Dec 5, 2024
@storyblok storyblok deleted a comment from notion-workspace bot Dec 5, 2024
@dipankarmaikap dipankarmaikap self-assigned this Dec 5, 2024
@edodusi edodusi force-pushed the chore/new-standard branch from d912d62 to fbe39c1 Compare December 6, 2024 15:06
Copy link
Contributor

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the QG

Copy link
Contributor

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dipankarmaikap amazing job you did here. Just one minor blocking point, I also added some commit suggestion to ease the changes required. Let me know if you have any questions or something you need support with

playground/ssg/astro.config.mjs Show resolved Hide resolved
playground/ssg/astro.config.mjs Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@alvarosabu alvarosabu self-requested a review December 12, 2024 10:42
@dipankarmaikap dipankarmaikap merged commit a2699f0 into main Dec 12, 2024
6 checks passed
@edodusi edodusi deleted the chore/new-standard branch December 16, 2024 08:49
Copy link

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants