fix: update typings to match api response #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagosaife
suggested changes
Jan 26, 2024
finnboeger
force-pushed
the
fix-typings
branch
from
116b19a to
be5e798
Compare
finnboeger
force-pushed
the
fix-typings
branch
from
be5e798 to
aaeec3e
Compare
finnboeger
commented
Jan 26, 2024
| parent_id: number | ||
| path?: string | ||
| pinned: '1' | boolean | ||
| pinned?: '1' | boolean |
There was a problem hiding this comment.
With the update to ISbMultipleStoriesData, this override here is unnecessary and could be removed.
ghost
merged commit 
|
🎉 This PR is included in version 6.6.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
How to test this PR
Request a random story and log the result, compare what you get with what the typing says you should've gotten.
Example:
What is the new behavior?
This fixes the typings that were broken in #697 and makes sure that the typing actually matches the API response.
All of these are on the
ISbStoryDatainterface.Many are fields have to be optional, as they are not always returned. I've marked them as optional as well, because you specifically requested that from the last fix, although the API does return
nullinstead in many cases, so this will still be slightly incorrect typing.One of the changes stands out, and that is marking
parentas optional. Anything else is impossible over JSON, as a recursive structure needs an anchor; the root element does not have a parent.Other information