Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnAlbin
Copy link

Updates version of PostCSS and webpack loaders

@productdevbook
Copy link

@phated

"style-loader": "^1.3.0"
"@storybook/node-logger": "^6.1.21",
"css-loader": "^5.2.0",
"postcss": "^8.2.8",
Copy link

@Asim-Tahir Asim-Tahir Jul 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#25 as stated
postcss must be >=8.2.10

@twhitbeck
Copy link

yo @JohnAlbin @phated can we get an update on why this hasn't been merged?

@jkklapp
Copy link

jkklapp commented Oct 27, 2021

Bump

@patrick-mcdougle
Copy link

Can we also add the peerDependency that yarn 2 needs to prevent these warnings:

➤ YN0002: │ @storybook/addon-postcss@npm:2.0.0 doesn't provide webpack (pb2910), requested by css-loader
➤ YN0002: │ @storybook/addon-postcss@npm:2.0.0 doesn't provide webpack (pec374), requested by postcss-loader
➤ YN0002: │ @storybook/addon-postcss@npm:2.0.0 doesn't provide webpack (pe4518), requested by style-loader

peerDependencies: {
  webpack: '^4.0.0 || ^5.0.0'
}

Since this package depends on the 3 loaders above which have webpack as peerDependencies and does not provide it, it should forward the peerDependencies on to the next consumer. See yarnpkg/berry#3 for further details.

@Yash-Singh1
Copy link

@knightly-bot build this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants