Fixes for v3 #70
Merged
Fixes for v3 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndelangen I've setup netlify deploy previews to build storybooks, please let me know if it works for you. I'm taking this opportunity to learn netlify :-) so not transferring this to an org yet. Happy to move this repo to an org (Storybooks?) if it make more sense in maintaining this. |
|
@ndelangen @xadn this is published as v3.0.0 (with a note on readme) Thanks so much! |
|
@xyc yeah I'm open to moving this repo under the storybook github org if you are, I'll invite you to the storybook org, so you can transfer. |
|
@ndelangen just transferred, thanks! |
|
@ndelangen I don't have admin / settings access to this repo now, do you mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys @ndelangen @xadn, I have made a few fixes before v3.0.0 release of this library. The major feature of v3 is @xadn's hook/new context API pr (#68, #69).
This PR fixes:
<ol>as root dom element (Make root dom element of <Inspector> not <li> #53)ƒobject.constructor.nameisObject, don't showObjectin the preview.Old:
▶Object {...}New:▶{...}▶ (20) {...}I'm intending other features in the backlog to be in a future release: detailed preview and long iterables #58, so that they could be implemented in a proper and extensible way.