chore: ui improvements #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for contributing 🙇♂️. Yes, the goal is to be similar to the web implementation where possible. In fact it's very much based on the web code. This seems quite reasonable. Always happy to receive contributions to improve anything. Unfortunately I'm unavailable for this whole week so im not able to check it right away. I will take a look as soon as I can. Thanks again. |
|
for future ui changes it would be cool to have some screenshots showing before/after if possible |
dannyhw
approved these changes
Jan 30, 2025
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: No issue created
What I did
Fixed some UI inconsistencies with current Storybook Web implementation.
There are a few mores I aim to fix, but I prefer to double check first that the intent is to be very similar to the Web version first.