Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Replace globby & glob with tinyglobby #29271

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 3, 2024

Closes #29227

What I did

  • replace glob with tinyglobby
  • replace globby with tinyglobby

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR replaces the usage of 'glob' and 'globby' packages with 'tinyglobby' across the Storybook codebase, aiming to reduce package size and dependencies while maintaining functionality.

  • Replaced 'glob' and 'globby' imports with 'tinyglobby' in multiple files, including core, builder-vite, cli-storybook, and codemod packages
  • Updated function calls and options to match tinyglobby API, e.g., renaming 'follow' to 'followSymbolicLinks'
  • Modified package.json files to remove 'glob' and 'globby' dependencies and add 'tinyglobby'
  • Updated test files to use 'tinyglobby' mocks instead of 'glob' or 'globby'
  • Ensured compatibility with existing glob patterns in Storybook's stories API

@ndelangen ndelangen self-assigned this Oct 3, 2024
@ndelangen ndelangen marked this pull request as draft October 3, 2024 10:24
@ndelangen ndelangen added maintenance User-facing maintenance tasks ci:normal labels Oct 3, 2024
Copy link

nx-cloud bot commented Oct 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b901b0a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen changed the title replace globby with tinyglobby Maintenance: Replace globby/glob with tinyglobby Oct 3, 2024
@ndelangen ndelangen changed the title Maintenance: Replace globby/glob with tinyglobby Maintenance: Replace globby & glob with tinyglobby Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate replacing glob and globby with tinyglobby
1 participant